On Fri, Jun 26, 2015 at 08:43:49AM +0200, Landry Breuil wrote: > On Fri, Jun 05, 2015 at 05:20:15PM +0300, Pavel Korovin wrote: > > Landry, thanks for your comments! > > Sorry for the unreadable diff, hope this time it's better. > > > > > > Maybe, but those cosmetic changes should be separate, otherwise the diff > > > > is unreadable. Unless someone beats me to it, i'll definitely look > > > > deeper into it next month.. (yeah, sorry), but USE_LIBTOOL shouldnt be > > > > needed iirc, and so far for new dependencies if they tended to be 'big' > > > > Collectd uses "--export-symbols-regex '\<module_register\>'" libtool option > > during modules build, and OpenBSD's libtool silently ignores it. > > And what's the actual issue here ? Is it a change from 5.4.x ?
I'm still not really comfortable with that, unless there's a real breakage i think i'd avoid it. What's the goal, having less symbols appearing in nm output on plugins ? > > > > (for various definitions of big) we put the corresponding plugins in a > > > > subpackage like it's done for the others. > > > > I dont't consider these new dependencies big (for example, we have curl > > module in the main package which requires libcurl); > > devel/libyajl dependency is shared between curl_json and log_logstash > > modules, so I decided to add yajl to the main build; devel/protobuf-c is > > also not a big dependency from my point of view, but if you think I'm > > wrong, it's not a big deal to move it to the separate package. > > > > > And i also think there were reasons for running collectd as root instead > > > of a dedicated use (kvm access? setuidsomething?) but i cant remember > > > them now... you'll also need to provide an upgrade path for existing > > > setups if you want to move to a dedicated user, and adapt the config > > > maybe ? > > > > Fixed. You are right, dns and ping modules require root, so I've added the > > README explaining this and the command to make collectd run as non-priv > > user, > > if these modules are not used. Also added simple "chgrp _collectd > > /etc/collectd.conf; chmod g+r /etc/collectd.conf" to the rc script to > > keep it running whenever it runs as root or as _collectd. > > Slowly coming back to this... i will try to test that. Note that i'll > probably backport https://github.com/collectd/collectd/pull/1095 which > just got merged upstream. Thought a bit more about this, what would happen with the datadir if it was first started as root, then one tried to run it as _collectd ? Should the rc script also do the chmod/chgrp dance for the datadir during rc_pre() ? What if the datadir is huge ? Landry
