On Fri, Jun 05, 2015 at 08:51:03AM +0200, Landry Breuil wrote: > On Thu, Jun 04, 2015 at 02:51:13PM +0300, Pavel Korovin wrote: > > On 06/04, Stuart Henderson wrote: > > > You only sent it yesterday, and mixed a bunch of style changes alongside > > > content changes (which is generally not wanted, and at the very least > > > makes > > > it difficult to review), and the person who has been most involved in the > > > collectd port recently has limited access to net at the moment > > > > Sure, I understand that people are usually busy and almost everyone involved > > with the OpenBSD project do everything in their spare time. > > > > I'm just a bit nervous if something is wrong with the diffs. > > I'm trying to get rid of my local ports tree submitting new ports/updates, > > but for now only some changes were submitted to textproc/elasticsearch. > > > > As of collectd port, I found that it bloats as time goes by, and it > > becomes harder and harder to keep up with it, so I decided to clean up the > > Makefile. > > Maybe, but those cosmetic changes should be separate, otherwise the diff > is unreadable. Unless someone beats me to it, i'll definitely look > deeper into it next month.. (yeah, sorry), but USE_LIBTOOL shouldnt be > needed iirc, and so far for new dependencies if they tended to be 'big' > (for various definitions of big) we put the corresponding plugins in a > subpackage like it's done for the others.
And i also think there were reasons for running collectd as root instead of a dedicated use (kvm access? setuidsomething?) but i cant remember them now... you'll also need to provide an upgrade path for existing setups if you want to move to a dedicated user, and adapt the config maybe ? Landry
