On 02/10/15 15:20, Florian Stinglmayr wrote:
> On Tue, Feb 10, 2015 at 02:42:31PM -0500, Brian Callahan wrote:
>> Hi Florian --
>>
>> It mostly looks ok (might want to tighten up some white space and/or
>> rearrange some variables but that's just nit-picking).
>> I had to regen the patches (there was fuzz).
>>
> I am not as nit-picky about variable ordering as many of you here on
> the list. But I like having the path related variables together, as I
> am sure they will need a lot of altering if upstream keeps changing the
> syntax of their tags and release names.
>
>> Also, and I may well demonstrate my lack of knowledge of luafs here,
>> going off your email is this something that should have FLAVORS added to
>> it? You say in your email that it adds support for lua53 yet it is built
>> with lua51. Could the version I built with lua51 work with lua53 things?
>> Do we even care about such things? I assume the answer to the latter
>> question is yes since you brought it up.
>>
> I assumed that such modules are built for different lua versions
> by overriding MODLUA_VERSION in the environment. Thus you end up with:
>
> * lua53fs-1.6.3 => Lua 5.3
> * lua52fs-1.6.3 => Lua 5.2
> * luafs-1.6.3 => Lua 5.1
>
> At least that is what I concluded after looking at the Lua ports module.
>
Right. Lua is the one that does it automagically.
>> Finally, do you want to take MAINTAINER of this? There is none
>> currently listed.
> Can do.
>
> And thanks for taking a peek at it Brian. Much obliged.
You still didn't regen your patches...
~Brian
> Florian
>
> Here is one with me as maintainer:
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/luafs/Makefile,v
> retrieving revision 1.19
> diff -u -p -u -r1.19 Makefile
> --- Makefile 7 Aug 2013 21:57:47 -0000 1.19
> +++ Makefile 10 Feb 2015 20:14:56 -0000
> @@ -1,22 +1,31 @@
> # $OpenBSD: Makefile,v 1.19 2013/08/07 21:57:47 naddy Exp $
> -SHARED_ONLY= Yes
> +SHARED_ONLY = Yes
>
> -COMMENT= file system library for the lua language
> -V= 1.6.2
> -DISTNAME= luafilesystem-${V}
> -PKGNAME= luafs-${V}
> -CATEGORIES= devel
> -MASTER_SITES=
> https://github.com/downloads/keplerproject/luafilesystem/
> +COMMENT = file system library for the lua language
> +V = 1_6_3
>
> -HOMEPAGE= http://www.keplerproject.org/luafilesystem/
> +GH_ACCOUNT = keplerproject
> +GH_PROJECT = luafilesystem
> +GH_TAGNAME = v_${V}
> +GH_COMMIT = 8014725009e195ffb502bcd65ca4e93b60a1b21c
> +
> +DISTNAME = ${GH_PROJECT}-v_${V}
> +WRKDIST = ${WRKDIR}/${DISTNAME}
> +PKGNAME = luafs-${V:S/_/./g}
> +
> +CATEGORIES = devel
> +
> +HOMEPAGE = http://www.keplerproject.org/luafilesystem/
> +
> +MAINTAINER = Florian Stinglmayr <flor...@n0la.org>
>
> # MIT
> -PERMIT_PACKAGE_CDROM= Yes
> +PERMIT_PACKAGE_CDROM = Yes
>
> -MODULES= lang/lua
> -ALL_TARGET= lib
> +MODULES = lang/lua
> +ALL_TARGET = lib
>
> -MAKE_ENV+= LUA_LIBDIR=${MODLUA_LIBDIR} LUA_INC=${MODLUA_INCL_DIR}
> +MAKE_ENV += LUA_LIBDIR=${MODLUA_LIBDIR} LUA_INC=${MODLUA_INCL_DIR}
>
> do-install:
> ${INSTALL_DATA_DIR} ${MODLUA_LIBDIR} ${MODLUA_DOCDIR}
> ${MODLUA_EXAMPLEDIR}
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/luafs/distinfo,v
> retrieving revision 1.8
> diff -u -p -u -r1.8 distinfo
> --- distinfo 7 Jan 2013 22:13:40 -0000 1.8
> +++ distinfo 10 Feb 2015 20:14:56 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (luafilesystem-1.6.2.tar.gz) =
> StFt+ZWDFGYqRZ/shI0jPVkxPvSZKAiikAU8FhRTIBg=
> -SIZE (luafilesystem-1.6.2.tar.gz) = 27886
> +SHA256 (luafilesystem-v_1_6_3.tar.gz) =
> VSXSuOx3dIZWKaainC+Uyw9+Z4eYe/VM034BG/tkIGg=
> +SIZE (luafilesystem-v_1_6_3.tar.gz) = 30379
>
