Hi Florian --
On 02/10/15 13:12, Florian Stinglmayr wrote:
> Hi list,
>
> down below is a patch to update devel/luafs to the latest version 1.6.3
> that also adds support for lua53. There is some variable magic in there
> that makes the update kind of ugly though. Can someone more experienced
> please take a look at this?
It mostly looks ok (might want to tighten up some white space and/or
rearrange some variables but that's just nit-picking).
I had to regen the patches (there was fuzz).
Also, and I may well demonstrate my lack of knowledge of luafs here,
going off your email is this something that should have FLAVORS added to
it? You say in your email that it adds support for lua53 yet it is built
with lua51. Could the version I built with lua51 work with lua53 things?
Do we even care about such things? I assume the answer to the latter
question is yes since you brought it up.
Finally, do you want to take MAINTAINER of this? There is none currently
listed.
~Brian
> Thanks,
> Florian
>
> P.S.: Consistent naming of tags is not luafilesystem's strong suite.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/luafs/Makefile,v
> retrieving revision 1.19
> diff -u -p -u -r1.19 Makefile
> --- Makefile 7 Aug 2013 21:57:47 -0000 1.19
> +++ Makefile 10 Feb 2015 18:02:45 -0000
> @@ -2,11 +2,18 @@
> SHARED_ONLY= Yes
>
> COMMENT= file system library for the lua language
> -V= 1.6.2
> -DISTNAME= luafilesystem-${V}
> -PKGNAME= luafs-${V}
> +V= 1_6_3
> +
> +GH_ACCOUNT= keplerproject
> +GH_PROJECT= luafilesystem
> +GH_TAGNAME= v_${V}
> +GH_COMMIT= 8014725009e195ffb502bcd65ca4e93b60a1b21c
> +
> +DISTNAME= ${GH_PROJECT}-v_${V}
> +WRKDIST= ${WRKDIR}/${DISTNAME}
> +PKGNAME= luafs-${V:S/_/./g}
> +
> CATEGORIES= devel
> -MASTER_SITES=
> https://github.com/downloads/keplerproject/luafilesystem/
>
> HOMEPAGE= http://www.keplerproject.org/luafilesystem/
>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/luafs/distinfo,v
> retrieving revision 1.8
> diff -u -p -u -r1.8 distinfo
> --- distinfo 7 Jan 2013 22:13:40 -0000 1.8
> +++ distinfo 10 Feb 2015 18:02:45 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (luafilesystem-1.6.2.tar.gz) =
> StFt+ZWDFGYqRZ/shI0jPVkxPvSZKAiikAU8FhRTIBg=
> -SIZE (luafilesystem-1.6.2.tar.gz) = 27886
> +SHA256 (luafilesystem-v_1_6_3.tar.gz) =
> VSXSuOx3dIZWKaainC+Uyw9+Z4eYe/VM034BG/tkIGg=
> +SIZE (luafilesystem-v_1_6_3.tar.gz) = 30379
>
