On Thu, Dec 11, 2014 at 5:22 PM, Masao Uebayashi <uebay...@tombi.co.jp> wrote: > Reflected your comments + others from zhuk@. Especially, in DESCR, mention > "valgrind-openbsd" page to report problems. > > Any explicit OK?
Looks good. Ok with me, and thanks for your work on valgrind! ciao, David > diff -Nru valgrind.orig/Makefile valgrind/Makefile > --- valgrind.orig/Makefile Thu Dec 4 22:59:34 2014 > +++ valgrind/Makefile Fri Dec 12 01:08:51 2014 > @@ -2,7 +2,7 @@ > > ONLY_FOR_ARCHS = amd64 > > -COMMENT = Instrumentation framework for dynamic analysis tools > +COMMENT = instrumentation framework for dynamic analysis tools > CATEGORIES = devel > > V = 3.10.1 > @@ -12,7 +12,7 @@ > MASTER_SITES = ${HOMEPAGE:=downloads/} > MASTER_SITES0 = > https://bitbucket.org/uebayasi/valgrind-openbsd/downloads/ > PATCH_DIST_STRIP = -p1 > -PATCHFILES = valgrind-${V}-openbsd-20141203.patch:0 > +PATCHFILES = valgrind-${V}-openbsd-20141211.patch:0 > > HOMEPAGE = http://www.valgrind.org/ > > @@ -21,6 +21,8 @@ > # GPLv2 > PERMIT_PACKAGE_CDROM = Yes > > +WANTLIB += c pthread > + > CONFIGURE_STYLE = gnu > USE_GMAKE = Yes > AUTOCONF_VERSION = 2.62 > @@ -29,7 +31,7 @@ > ${MODGNU_AUTOMAKE_DEPENDS} > > pre-configure: > - @cd ${WRKBUILD} && \ > + @cd ${WRKSRC} && \ > env \ > AUTOCONF_VERSION=${AUTOCONF_VERSION} \ > AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \ > diff -Nru valgrind.orig/distinfo valgrind/distinfo > --- valgrind.orig/distinfo Wed Dec 3 17:55:39 2014 > +++ valgrind/distinfo Fri Dec 12 01:09:43 2014 > @@ -1,4 +1,4 @@ > -SHA256 (valgrind-3.10.1-openbsd-20141203.patch) = > cF8uxzWr02CEss53IdlNDKTdwXfR2j/9DyJ+DLIl3XM= > +SHA256 (valgrind-3.10.1-openbsd-20141211.patch) = > qYHdIy0yj4savTwGDgStqXHs4MB4R38jndQNZtf4Zqg= > SHA256 (valgrind-3.10.1.tar.bz2) = > +iU9wm3bZhtiad9YFE7/YH6j92qbz+V0sMdybh38uZc= > -SIZE (valgrind-3.10.1-openbsd-20141203.patch) = 1234600 > +SIZE (valgrind-3.10.1-openbsd-20141211.patch) = 1235560 > SIZE (valgrind-3.10.1.tar.bz2) = 10967905 > diff -Nru valgrind.orig/pkg/DESCR valgrind/pkg/DESCR > --- valgrind.orig/pkg/DESCR Thu Dec 4 23:07:10 2014 > +++ valgrind/pkg/DESCR Fri Dec 12 01:07:56 2014 > @@ -2,3 +2,8 @@ > tools. There are Valgrind tools that can automatically detect many memory > management and threading bugs, and profile your programs in detail. You > can also use Valgrind to build new tools. > + > +This OpenBSD port is still very preliminary and has minimal functionality > +(memcheck). All problems should be reported to the "valgrind-openbsd" page: > + > +https://bitbucket.org/uebayasi/valgrind-openbsd/ > -- "If you try a few times and give up, you'll never get there. But if you keep at it... There's a lot of problems in the world which can really be solved by applying two or three times the persistence that other people will." -- Stewart Nelson