On 2014/12/11 16:24, Masao Uebayashi wrote:
> Here is the first attempt to port Valgrind to OpenBSD/amd64.  Heavily based
> on that of FreeBSD.
> 
>       https://wiki.freebsd.org/Valgrind
>       https://bitbucket.org/stass/valgrind-freebsd

I have a few minor tweaks,

>COMMENT =               Instrumentation framework for dynamic analysis tools

- please use lower-case at the start of COMMENT, i.e.

COMMENT =               instrumentation framework for dynamic analysis tools

...

>pre-configure:
>        @cd ${WRKBUILD} && \

- autogen should be run in WRKSRC not WRKBUILD. (by default they point
to the same directory, but this changes if you use SEPARATE_BUILD=Yes).

$ make port-lib-depends-check
valgrind-3.10.1(devel/valgrind):
Missing: c.78 (/usr/local/lib/valgrind/getoff-amd64-openbsd) (system lib)
Missing: pthread.18 (/usr/local/bin/vgdb) (system lib)
WANTLIB += c pthread
*** Error 1 in target 'port-lib-depends-check' (ignored)

- Add "WANTLIB += c pthread" (between PERMIT_* and CONFIGURE_STYLE).

> Minimal functionality, considered to be alpha release.

It is probably worth mentioning this in pkg/DESCR.

Reply via email to