Hi Kirill, > http://i386.linklevel.net/munin/linklevel.net/manaraga.linklevel.net/pf_changes.html > - without patch > Have you tweaked your /etc/munin/plugin-conf.d/openbsd-packages? > You need to set `user root` for pf_* plugins.
Yes, of course, two other pf_* plugins are working fine, except this one. > >> >> To explain my setup: I've a munin-node-2.0.21 on OpenBSD 5.6 and an >> ancient munin-1.4.5 on Linux collector node. > > I'm not really sure munin 2.x is compatible with 1.x, but your patch is needed > for consistency. > >> >> One can argue, that elder versions are not supposed to be supported, but >> assuming a general goal of OpenBSD be >> code correctness and portability this patch seems mandatory to me. >> Particularly because this is a OpenBSD own maintained module. > > > Sorry, missed that point. Some remarks for future - send patches generated by > `cvs diff -uNp`. If you've send such a patch this time, I've recognised it was > for plugin in $FILESDIR and not for upstream plugin. Sorry, my fault. The patch is so trivial and oblivious, that I missed that point. > BTW, we have a discussion about locally maintained plugins couple of days ago > and it was decided that It's better to maintain OpenBSD specific plugins in > ports-tree and don't try to push them upstream. > > I'll commit your patch tomorrow. > Thanks for patch. Thank you very much! wbr, Dima -- Dimitri Sokolyuk — 0x5a7c3054 — http://www.dim13.org/
