Hi Kirill, Nop. At least, this is what I get on the collector node without this patch:
2014/11/06 00:40:38 [WARNING] munin_set_var_loc: Setting unknown
option 'value' at site;uplink.site:pf_changes.ins
2014/11/06 00:40:38 [WARNING] munin_set_var_loc: Setting unknown
option 'value' at site;uplink.site:pf_changes.rem
The graph is also not being displayed.
To explain my setup: I've a munin-node-2.0.21 on OpenBSD 5.6 and an
ancient munin-1.4.5 on Linux collector node.
One can argue, that elder versions are not supposed to be supported, but
assuming a general goal of OpenBSD be
code correctness and portability this patch seems mandatory to me.
Particularly because this is a OpenBSD own maintained module.
> You should report this upstream (and send them a patch).
But, aren't you a maintainer of this port? Then my apologies. If it's so
this has to be corrected as well. ;)
wbr,
Dima
On 11/07/2014 04:40 PM, Kirill Bychkov wrote:
> On Fri, November 7, 2014 18:34, Kirill Bychkov wrote:
>> On Thu, November 6, 2014 20:47, Dimitri Sokolyuk wrote:
>>> Hallo Kirill,
>>>
>>> there is a small bug in pf_changes plugin: an exit command is missing in
>>> `config' part, without wich munin fails to autoconfigure this plugin.
>>> Could you please update the port?
>> Hi, Dimitri.
>> Patch seems to be correct, but I'm not sure there is a reason to add this
>> patch to munin port - it doesn't break runtime. You should report this
>> upstream (and send them a patch).
> I mean plugin is operating correct without this patch.
>
>>> thanks & wbr,
>>> Dima
>>>
>>> --- pf_changes.orig Thu Nov 6 18:40:33 2014
>>> +++ pf_changes Thu Nov 6 00:38:30 2014
>>> @@ -41,6 +41,7 @@
>>> echo 'rem.info State table entry removals'
>>> echo 'rem.type DERIVE'
>>> echo 'ins.min 0'
>>> + exit 0
>>> fi
>>>
>>> pfctl -si | awk '
>>>
>>
>>
>
--
Dimitri Sokolyuk -- http://www.dim13.org/
signature.asc
Description: OpenPGP digital signature
