On 2014/09/08 19:05, Henrik Friedrichsen wrote: > On Mon, Sep 08, 2014 at 08:14:00PM +0400, Vadim Zhukov wrote: > > From compile output: > > > > 1) Hidden/broken dependency? See the devel/libexecinfo port for details. > > <stdin>:1:22: error: execinfo.h: No such file or directory > Well, no. It is not a mandatory dependency, but only required for > printing backtraces on crashes.
Chances are it won't actually work directly on OpenBSD anyway without forcing it to link against the backtrace lib, but many ports have autoconf probes for the headers. Problem occurs if autoconf picks it up when probing for available files, if you don't list it as a dependency or prevent autoconf from picking it up, then DPB builds will likely fail on occasion as they install and uninstall the libexecinfo package behind dwb's back. In general: anything which configure scripts might pick up should either be listed as a dependency, or explicitly disabled. > > 3) It looks like pick up a real issue here. But I didn't dig deep, > > maybe, it's guaranteed that there won't be more than 512 bytes of > > data... Please check. > I didn't bother to check, but it can't hurt to simply replace it > with the safer alternative. Done. from strlcat manual, "If the return value is >= dstsize, the output string has been truncated. It is the caller's responsibility to handle this." ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
