2014-09-08 19:59 GMT+04:00 Henrik Friedrichsen <hen...@diff.cc>:
> On Mon, Sep 08, 2014 at 04:58:44PM +0200, Landry Breuil wrote:
>> With that minor nit fixed (and the
>> dozens of extra tabs in the makefile removed :), ok for
>> me to anyone who wants to import it.
>
> Heh, okay. One more try ;)

>From compile output:

1) Hidden/broken dependency? See the devel/libexecinfo port for details.
<stdin>:1:22: error: execinfo.h: No such file or directory

2) Needs patching (32-bit archs won't be happy otherwise):
util.c:37: warning: format '%lu' expects type 'long unsigned int', but
argument 3 has type 'time_t'
dwbem.c:856: warning: format '%lu' expects type 'long unsigned int',
but argument 4 has type 'time_t'

3) It looks like pick up a real issue here. But I didn't dig deep,
maybe, it's guaranteed that there won't be more than 512 bytes of
data... Please check.

/usr/obj/p/dwb-2014.03.07/dwb-2014.03.07/src/util/mktlds-header.c:174:
warning: strcat() is almost always misused, please use strlcat()

Also, please clean up the DESCR: capitalize "gtk", shrink the "web
browser based on the webkit web browser engine" phrase and so on.

--
  WBR,
  Vadim Zhukov

Reply via email to