Dear Brian, Stuart, I have been out for some days, so sorry for the late reply. Thank you for your comments, I hope I have improved the port.
On 20 Jun 2014 18:43, Brian Callahan wrote:
>
> On 06/20/14 18:31, Stuart Henderson wrote:
> >Quick comments from reading:
> >
> >examples should go in the standard directory layout i.e.
> >/usr/local/share/examples/bspwm (and get rid of MESSAGE)
Done.
> >
> >+CFLAGS += -std=c99 -pedantic -Wall -Wextra -I$(PREFIX)/include
> >-I/usr/X11R6/include
> >- don't hardcode usr/X11R6, use the X11BASE variable
Done.
> >
> >pkg/DESCR needs wrapping
Done.
> >
> >share/man/man1/ should be man/man1
OK!
> >
> >"2-Clause BSD License", just use "BSD"
Gotcha. Done.
> >
> >Makefile missing rcs id comment line
I think i got it right, as I'm not too sure on what to add here. Please
correct me if that's not right.
> >
> >post-install: use ${INSTALL_DATA_DIR} not mkdir
OK. I also did the do-install: target that Brian suggested.
> >
> >DISTFILES=0.8.8.tar.gz is bad, you can use something like
> >
> >V= 0.8.8
> >DISTNAME= bspwm-$V
> >DISTFILES= ${DISTNAME}{v$V}${EXTRACT_SUFX}
Good idea. Done.
> Few more comments:
> COMMENT should not start with "a"
Done.
>
> You don't need USE_GMAKE. Built just fine without it.
Yep, but had to remove an extra CFLAGS += '-Os', and an LDFLAGS += '-s'.
Should I keep the -Os? The extra LDFLAG is not necessary, as it's the
default for the ${INSTALL_PROGRAM} routine, isn't it?
>
> The install routine is a bunch of "mkdir -p" and "cp" - maybe it's better to
> use a do-install routine here.
Done.
>
> Your WANTLIB line is almost entirely bogus. I get this:
> WANTLIB += c m xcb xcb-ewmh xcb-icccm xcb-randr xcb-xinerama
> Run make port-lib-depends-check.
Strange, maybe I issued another depends-check. I got the same line as
yours now.
>
> You need NO_TEST=Yes
Added.
--
Enric Morales <[email protected]>
bspwm.tar.gz
Description: application/tar-gz
