On 2014/06/21 00:19, Enric Morales wrote:
> Here is the attachment, I screwed up the file, so sorry for spamming the
> list.

Quick comments from reading:

examples should go in the standard directory layout i.e.
/usr/local/share/examples/bspwm (and get rid of MESSAGE)

+CFLAGS  += -std=c99 -pedantic -Wall -Wextra -I$(PREFIX)/include 
-I/usr/X11R6/include
- don't hardcode usr/X11R6, use the X11BASE variable

pkg/DESCR needs wrapping

share/man/man1/ should be man/man1

"2-Clause BSD License", just use "BSD"

Makefile missing rcs id comment line

post-install: use ${INSTALL_DATA_DIR} not mkdir

DISTFILES=0.8.8.tar.gz is bad, you can use something like

V=              0.8.8
DISTNAME=       bspwm-$V
DISTFILES=      ${DISTNAME}{v$V}${EXTRACT_SUFX}



Reply via email to