LEVAI Daniel <l...@ecentrum.hu> writes: > On h, dec 23, 2013 at 18:20:12 +0100, Jérémie Courrèges-Anglas wrote: >> "Dmitrij D. Czarkoff" <czark...@gmail.com> writes: >> >> > LEVAI Daniel said: >> >> I don't mind having the pwsafe convert utility around, I just tought >> >> that generally the expectation is that if something gets installed, then >> >> it should (or supposed to) work :) If it's enough (from the user point >> >> of view) that perl will warn the user that some modules are necessary >> >> for running said program, then I'm okay with installing it henceforward. >> >> If this is the case, I guess the pkg-readme could also stay, but with >> >> some modifications that mention the perl module dependency. Is this an >> >> acceptable standard in the ports tree? >> > >> > I would drop the readme from the patch and either drop it from PLIST or >> > (if it is worth having) make a subpackage. >> >> I don't think the complexity of subpackages are worth it, I'd just ship >> the script as is, with a note in the readme. > > > This seems fine, but why did you remove the test target?
I did not, "test" is the default for TEST_TARGET when not modified by some module. If a port doesn't have a test suite then NO_TEST = Yes should be used. Cheers, -- jca | PGP: 0x06A11494 / 61DB D9A0 00A4 67CF 2A90 8961 6191 8FBF 06A1 1494
