On 09/20/13 23:48, Kyle R W Milz wrote:
On Fri, Sep 20, 2013 at 09:30:21PM +0200, Juan Francisco Cantero Hurtado wrote:
On Fri, Sep 20, 2013 at 09:33:27AM -0600, Kyle R W Milz wrote:
ports@,
Thanks everyone for the feedback, here is an update with changes made.
Things I'm wary about still:
- had to set DESTDIRNAME = / to `make package' properly, there's some
sort of weird double path thing going on if not
- this thing needs root to run, does it make sense to be in bin/ ?
"LDFLAGS += -Wl" in the patch is wrong. You're passing literally nothing
to the linker.
OK nuked the entire line.
Don't use DESTDIRNAME. The software reads PREFIX and DESTDIR, so it
concatenates both paths. You need to patch the install part of the
makefile of radeontop.
Not sure what you're trying to say here but I've removed the DESTDIRNAME
from the port Makefile and replaced ${PREFIX} in the radeontop Makefile
with ${LOCALBASE} after reading in bsd.port.mk that $PREFIX is usually
set to $LOCALBASE anyways.
I was speaking about
/usr/ports/pobj/radeontop-0.6/fake-amd64//usr/ports/pobj/radeontop-0.6/fake-amd64/usr/local/bin/radeontop.
When I said "The software" I was speaking about the makefile of
radeontop. Sometimes my wording is terrible.
The idea of jca@ with a void DESTDIR within FAKE_FLAGS is the best.
It'll simplify your work as maintainer in the future.
You also didn't clarify whether or not this should be in bin/ or sbin/
so I moved it back to sbin/ because like I said before this thing needs
root to run (mmap /dev/mem).
Sorry for not responding directly to your questions, I didn't receive
your mails. Apparently openbsd.org and my mail provider are fighting to
death this week. Each mail sent take two hours to arrive to openbsd.org.
I prefer "bin" but this is subjetive :)
