On 2009/09/30 17:11, Edd Barrett wrote:
> On Sat, Sep 26, 2009 at 03:22:19PM +0100, Edd Barrett wrote:
> > Ok, well heres the a diff which continues from Kili's work, dealing with
> > faac stuff. Now what I would like is a authoritive "remove that GUI!"
> > from a comitter :) Any takers?
> 
> Heres a diff with the GUI stripped. --disable-gui significantly stripped
> WANTLIB and caused a whole bunch of gui related files to go away
> including the entirety of those in the PFRAG.

good :)

I think this is nearly ready, it would be good to get this in soon.

> +# our bintools does not do sse3 for i386/amd64

this should be "bintools 2.15 does not [...]", so the comment is
still valid when it's updated.

>  .if ${MACHINE_ARCH:Mpowerpc}
>  CONFIGURE_ARGS+=--disable-altivec
> +CONFIGURE_ARGS+=--enable-runtime-cpudetection
>  .endif

if this is also due to old bintools, there should be a similar
comment here too.

>  .if ${MACHINE_ARCH:Marm}
>  CONFIGURE_ARGS+=--disable-mp3lib
> +CONFIGURE_ARGS+=--target=generic-openbsd

and this definitely is due to old bintools, same thing.

>  .if ${MACHINE_ARCH:Mi386}
>  CONFIGURE_ARGS+=--win32codecsdir=${LOCALBASE}/lib/win32 \
...
> +i386:
> +  MPlayer can use win32 codecs if they are installed (package
> +  win32-codecs) and if machdep.userldt is enabled via sysctl(8):
> +
> +  # sysctl machdep.userldt=1
> +
> +  Also note that MPlayer may sometimes fail to play a file (particularly
> +  WMV files) unless machdep.userldt is enabled, even though it can play
> +  the file without win32 codecs being installed.

didn't the discussion come out in favour of disabling win32-codecs?

Reply via email to