On Wed, Sep 23, 2009 at 07:43:18PM +0100, Edd Barrett wrote: > On Mon, Sep 21, 2009 at 10:02:34PM +0000, Jacob Meuser wrote: > > On Mon, Sep 21, 2009 at 02:37:29PM +0100, Edd Barrett wrote: > > > On Sun, Sep 20, 2009 at 07:59:43PM +0000, Jacob Meuser wrote: > > > > > + --enable-faac \ > > > > > + --disable-faac-lavc \ > > > > > + --extra-libs-mencoder=-lfaac \ > > > > > > > > why? > > > > > > To get external faac linked. > > > > --disable-faac-lavc has nothing to do with that. > > > > if the configure script isn't detecting external faac and adding -lfaac > > correctly, it should be fixed. I'd like to see configure.log from > > a system where this *fails*, because it works fine for me. > > Removing those 3 lines, you get and mplayer and mencoder linking faac, > is that correct? I seem to recall only mencoder should? Can't remember > who told me that off the top of my head.
yes, you do end up with mplayer linking libfaac. however, if we ever are going to have mplayer using external ffmpeg libs, which I do hope we can some day, this will have to be the case, or there will be unresolved symbols. and it was me who said before only mencoder should link libfaac. ok, I was wrong. I said that because adding -lfaac to LDFLAGS, as in previous versions, is not a good idea, because it links faac into all binaries (and in all link tests in the configure script). -- jake...@sdf.lonestar.org SDF Public Access UNIX System - http://sdf.lonestar.org
