Stuart Henderson wrote:
On 2008/12/11 10:44, LÉVAI Dániel wrote:
 PKGNAME-main=  ${DISTNAME}p0

this can go completely

-PKGNAME-python= py-rrd-${VERSION}p1
+PKGNAME-python= py-rrd-${VERSION}p0

and remove p0 here

 SHARED_LIBS+=  rrd 3.0
 SHARED_LIBS+=  rrd_th 3.0

diff doesn't show any API changes so that looks alright, but you should
always check (and if you did already check, please mention that :-)
I'll do that next time, sorry.


+-# rules for buildung the ruby module
++# rules for building the ruby module
+-# rules for buildung the pyton module
++# rules for building the python module

it's pointless to fix these in a ports diff, please just send them upstream
Alright.


+-#if defined(HAVE_SYS_MMAN_H)
+-#include <sys/mman.h>
+-#endif
+-
+ #ifdef HAVE_SYS_TYPES_H
+ # include <sys/types.h>
++#endif
++
++#if defined(HAVE_SYS_MMAN_H)
++#include <sys/mman.h>
+ #endif

I agree with doing that here for now but it also should go upstream.
Okay, I'll send them.

WANTLIB-perl needed an update, and the PLISTs needed changing.
I'll send an updated diff to the port's maintainer.
Thank you!
Daniel

--
LEVAI Daniel
PGP key ID = 0x4AC0A4B1
Key fingerprint = D037 03B9 C12D D338 4412  2D83 1373 917A 4AC0 A4B1

Reply via email to