On Sun, Jun 22, 2008 at 12:58:50PM +0200, frantisek holop wrote:
[...]
> anyway, it's an update then :]
Cool. Could you please make this into a unified diff, then? Diffing
the current port against your tarball produces lots of noise; it
would be much easier to review as a unified diff.
Based on the quick diff I did, though, some comments:
* Please use MODPY_EGG_VERSION (as in the current port) instead of
eg V and SUBST_VARS (as in your version).
* pkg/DESCR should have _some_ little bit of prose explaining the
port; the version in the tree seems more useful.
* Might as well use the INSTALL_DATA command instead of cp(1) when
installing documentation.
> whos the maintainer? noone's in the makefile...
Then we (ports@openbsd.org) are.
Thanks!
--
o--------------------------{ Will Maier }--------------------------o
| web:.......http://www.lfod.us/ | [EMAIL PROTECTED] |
*---------------------[ BSD: Live Free or Die ]--------------------*
