On Fri, Feb 07, 2025 at 08:47:17PM +0100, Rafael Sadowski wrote: > On Fri Feb 07, 2025 at 05:40:19PM +0000, Stuart Henderson wrote: > > On 2025/02/07 18:04, Rafael Sadowski wrote: > > > I would like to import grpc-1.70.1, as a dependency for bear(1). > > > > > > Tweaks, ok to import? > > > > > > Information for inst:grpc-1.70.1 > > > > > > Comment: > > > HTTP/2-based RPC framework > > > > > > Required by: > > > bear-3.1.5 > > > > > > Description: > > > gRPC is a modern, open source, high-performance remote procedure call > > > (RPC) > > > framework that can run anywhere. gRPC enables client and server > > > applications to > > > communicate transparently, and simplifies the building of connected > > > systems. > > > > > > This package includes plugins for C++, C#, Node.JS, Objective-C, PHP, > > > Python, > > > Ruby. > > > > I don't think we want share/grpc/roots.pem (copy of mozilla's CA bundle), > > it should probably be told to look at /etc/ssl/cert.pem instead. > > Thanks for the feedback! > > Good point. I have removed the installation task and changed the the > src/core/lib/security/security_connector/ssl_utils.cc to use /etc/ssl/cert.pem > > > > > Do you have a handle on what things in ports might pick it up if present > > at build time? It's not really greppable in bulk build logs unfortunately. > > When I ported this, I orientated myself on the FreeBSD port. The list of > consumers was very small and nothing seemed to me to be a problem for us: > https://www.freshports.org/devel/grpc
It mostly looks good to me ports-wise, although I'm not at all convinced by the devel/bear use case. It feels very expensive for what it provides. I guess I'm just not the target audience. That's fine. Do we really want or need to ship these, especially the systemd one? lib/cmake/grpc/modules/ lib/cmake/grpc/modules/Findc-ares.cmake lib/cmake/grpc/modules/Findre2.cmake lib/cmake/grpc/modules/Findsystemd.cmake I am really reluctant okaying this just because it is yet another Google C++ monster that will significantly add to bulk build times. I can live very well without this and its only prospective consumer. On the other hand, nobody's really objected so far... What do others think? Yay or nay? All that said, if this goes in, I'm ok with importing devel/bear. > > > > > What's going on with plugins? I see grp_xxx_plugin binaries in PLIST, > > but they don't look like anything I recognise as a plugin for any of > > those languages..(and I wouldn't want plugins for those languages all in > > a single port, e.g. their PHP stuff is https://pecl.php.net/package/gRPC > > and built using normal pecl mechanisms, from a ports point of view it > > will be a pain to handle all of these in one place due to interactions > > between MODULES). Are those binaries actually useful for anything? > > > > The same, copied from FreeBSD. I agree with you to disable all plugins. > I have no current use-case for it. > > New tarball attached.
