On 2025/03/16 17:30, Philip Kaludercic wrote:
> "Hukadan" <m...@hukadan.org> writes:
> 
> > On Fri Mar 7, 2025 at 12:27 AM CET, Stuart Henderson wrote:
> >> On 2025/03/06 19:48, Philip Kaludercic wrote:
> >> > Stuart Henderson <s...@spacehopper.org> writes:
> >> > 
> >> > > On 2024/07/31 16:32, Stuart Henderson wrote:
> >> > >> Ok with you, Hukadan?
> >> > >> 
> >> > >> https://marc.info/?l=openbsd-ports&m=172226686214725&w=2
> >> > >
> >> > > tb@ pointed out that this breaks with go-1.23rc2:
> >> > >
> >> > > # github.com/superseriousbusiness/gotosocial/cmd/gotosocial
> >> > > link: codeberg.org/gruf/go-fastcopy: invalid reference to
> >> > > io.errInvalidWrite
> >> > >
> >> > > This can be worked around with the following snippet:
> >> > >
> >> > > # disable https://go.dev/doc/go1.23#linker to unbreak with go-1.23rc2.
> >> > > # remove either if codeberg.org/gruf/go-fastcopy is fixed, or "existing
> >> > > # usages of //go:linkname found in a large open-source code corpus
> >> > > # remain supported" is extended.
> >> > > MODGO_LDFLAGS += -checklinkname=0
> >> > >
> >> > > That part can't be committed before go-1.23, and I doubt it would be
> >> > > needed for long, gotosocial is actively developed.
> >> > 
> >> > Sorry to ping this thread again, but I don't remember what the result
> >> > was and there has since been an apparently important security release
> >> > https://github.com/superseriousbusiness/gotosocial/releases/tag/v0.17.4
> >> > that might be nice to have in ports before the next release of OpenBSD?
> >>
> >> If I understand correctly GTS doesn't run properly on OS without coherent
> >> file + mmap access (i.e. unified buffer cache) any more, so we should
> >> probably delete the port..

(OpenBSD is different to most other OS in regards to behaviour when a
file is accessed via both mmap and file functions at the same time,
requiring additional syncs - I am not 100% certain but I think this
may be one of the things that the journal WAL is running into - the
type of corruption that could be caused by this is unlikely to be fun).

> >
> > Hi,
> >
> > @Philip, following this thread, I provided a diff a while ago (at that time 
> > to
> > update to 0.17.1).
> >
> > I do not use this port anymore. I don't feel confident in being able
> > to maintain
> > it, especially without being able to test it properly.
> 
> I have an active server that I would like to keep on using.  If I have
> to figure out how to fix whatever issues gotosocial has on OpenBSD, I am
> happy to share these findings here (IIRC the mmap issue was related
> gotosocial bundling ffmpeg and some other tools in wasm form, which we
> don't have to do).  Sadly I am not familiar with the inner workings of
> the ports system, so I would appreciate any pointers here.

There is "nowasm", but that switches back to the modernc.org-based sqlite.

That does now run (since they adapted to system call changes in OpenBSD)
but another problem was mentioned afterwards:

https://github.com/superseriousbusiness/gotosocial/issues/1710#issuecomment-1526244856

which...upstream worked around by switching to wasm sqlite. Also, they
say:

!!! Danger "No really though, it's unsupported" Again, if running builds
    of GoToSocial with nowasm works for your OS/Arch combination, that's
    great, but we do not support such builds and we won't be able to help
    debugging why something doesn't work.

(https://github.com/superseriousbusiness/gotosocial/blob/HEAD/docs/advanced/builds/nowasm.md)

I am not really confident in this code running reliably on OpenBSD.
To keep it in ports I'd really want to see an active maintainer who
understands the issues and well able to test; otherwise I don't think
keeping this in ports is a good service to the fedi ecosystem, to
gotosocial upstream, or to our users.

I propose this..


Index: www/Makefile
===================================================================
RCS file: /cvs/ports/www/Makefile,v
diff -u -p -r1.1145 Makefile
--- www/Makefile        21 Feb 2025 11:40:10 -0000      1.1145
+++ www/Makefile        18 Mar 2025 14:51:00 -0000
@@ -52,7 +52,6 @@
      SUBDIR += geckodriver
      SUBDIR += gitea
      SUBDIR += goaccess
-     SUBDIR += gotosocial
      SUBDIR += gumbo
      SUBDIR += haserl
      SUBDIR += haserl,no_lua
Index: devel/quirks/Makefile
===================================================================
RCS file: /cvs/ports/devel/quirks/Makefile,v
diff -u -p -r1.1694 Makefile
--- devel/quirks/Makefile       12 Mar 2025 11:01:48 -0000      1.1694
+++ devel/quirks/Makefile       18 Mar 2025 14:51:00 -0000
@@ -3,7 +3,7 @@ CATEGORIES =    devel databases
 DISTFILES =
 
 # API.rev
-PKGNAME =      quirks-7.101
+PKGNAME =      quirks-7.102
 PKG_ARCH =     *
 MAINTAINER =   Marc Espie <es...@openbsd.org>
 
Index: devel/quirks/files/Quirks.pm
===================================================================
RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v
diff -u -p -r1.1706 Quirks.pm
--- devel/quirks/files/Quirks.pm        12 Mar 2025 11:01:48 -0000      1.1706
+++ devel/quirks/files/Quirks.pm        18 Mar 2025 14:51:00 -0000
@@ -1243,6 +1243,7 @@ setup_obsolete_reason(
        6 => 'py3-setuptools-git',
        11 => 'rpki-data',
        5 => 'pycha',
+       10 => 'gotosocial',
 );
 
 # though it's not yet used, these should be pkgnames, so that eventually
@@ -1276,6 +1277,7 @@ my $obsolete_message = {
        7 => "removed in favor of using the language's package manager",
        8 => "no longer maintained upstream, consider mapproxy as an 
alternative",
        9 => "removed, needs a port maintainer",
+       10 => "other OS suggested, or see 
https://docs.gotosocial.org/en/latest/advanced/builds/nowasm/";,
        11 => "no longer packageable",
        13 => "has a dependency on obsolete software",
        15 => "use rspamd's internal milter support instead",

Reply via email to