On Fri 27/12/2024 16:00, Kirill A. Korinsky wrote:
> On Fri, 27 Dec 2024 14:36:18 +0100,
> Bjorn Ketelaars <b...@openbsd.org> wrote:
> >
> > On Fri 27/12/2024 14:13, Kirill A. Korinsky wrote:
> > > On Fri, 27 Dec 2024 07:29:24 +0100,
> > > Bjorn Ketelaars <b...@openbsd.org> wrote:
> > > >
> > > >
> > > > I added aisha@ (maintainer) to the Cc. As this release contains a
> > > > security fix I will commit later today, unless someone disagrees.
> > > >
> > >
> > > I really think that we should backport it to -stable as well.
> > >
> > > But it requires rust at least 1.82 since
> > > https://github.com/dani-garcia/vaultwarden/commit/71b3d3c818db846bb1972ed79188b3709b9f822b
> > >
> > > Here the diff which includes a patch to support rust 1.81 which I had
> > > tested
> > > on -stable/amd64, and it works well.
> > >
> > > Ok?
Builds on 7.6, and very lightly run tested. Works for me.
Please note that your diff also creates 2 remnant files:
patches/patch-Cargo_toml.orig and patches/patch-src_api_icons_rs.orig.
See below. I think it makes sense to double check that these files are
not committed.
> RCS file: security/vaultwarden/patches/patch-Cargo_toml.orig
> diff -N security/vaultwarden/patches/patch-Cargo_toml.orig
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ security/vaultwarden/patches/patch-Cargo_toml.orig 27 Dec 2024
> 14:56:46 -0000
> RCS file: security/vaultwarden/patches/patch-src_api_icons_rs.orig
> diff -N security/vaultwarden/patches/patch-src_api_icons_rs.orig
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ security/vaultwarden/patches/patch-src_api_icons_rs.orig 27 Dec 2024
> 14:56:46 -0000
While compiling I'm seeing the warning below. No biggie, but there is an
opportunity to address this in your patch for api_icons.rs.
warning: variable `maybeToken` should have a snake case name
--> src/api/icons.rs:273:9
|
273 | for maybeToken in dom {
| ^^^^^^^^^^ help: convert the identifier to snake case:
`maybe_token`
|
= note: `#[warn(non_snake_case)]` on by default
