09.11.2024 03:37, Paul Galbraith пишет:
> On 2024-10-24 4:26 p.m., Paul Galbraith wrote:
>> On 2024-10-23 3:33 a.m., Stuart Henderson wrote:
>>> Thanks. Couple of small things:
>>>
>>> - it's unfortunate about the name conflict, but it's unavoidable for
>>> "b2". I'd prefer not to rename b2v3/b2v4 though. For one thing, upstream
>>> recommends using a numbered version in scripts ("for long-term support,
>>> i.e. in scripts, use b2v4 command"). For another it will remove some text
>>> from MESSAGE which should be as short as possible - we find people tend
>>> to ignore larger chunks of text at the end of pkg_add so best keep it
>>> short and to the point. I think users can be expected to figure out
>>> symlinks or shell aliases themselves too, so I'd go with just this for
>>> MESSAGE:
>>>
>>> The b2 CLI utility has been renamed to backblaze-b2 to avoid a conflict
>>> with the Boost b2 utility.
>>>
>>> - the idna dependency is listed upstream with
>>> "idna~=3.4; platform_system == 'Java'" and doesn't seem to
>>> be used in the code; is that actually needed?
>>>
>>> With the first of those changes, and the secomnd if appropriate, it's
>>> ok sthen.
>>
>> Thanks for taking a look, Stuart. I've made these changes and also bumped
>> the version to the latest release.
>>
> Can anyone spare a few minutes to import? TIA,
>
> Paul
>
Makefile has spaces instead of tabs after =.
Deps are not sorted.
NO_TEST=Yes seems correct as there are no tests in the distfile, but the comment
reads as if there were some, which fail due to account+network requirements.
PKGNAME can be simpler backblaze-${DISTNAME}.
Subject says net/ but CATEGORIES has sysutils; perhaps net and sysutils?
The main program can be renamed in post-install, no need for a patch:
post-install:
mv ${PREFIX}/bin/{,backblaze-}b2
