On 2024/10/22 10:55, Paul Galbraith wrote:
> On 2024-10-22 5:22 a.m., Stuart Henderson wrote:
> > Can you reattach the port please so we don't need to go looking in the
> > archives.
> Sure thing, attached.
Thanks. Couple of small things:
- it's unfortunate about the name conflict, but it's unavoidable for
"b2". I'd prefer not to rename b2v3/b2v4 though. For one thing, upstream
recommends using a numbered version in scripts ("for long-term support,
i.e. in scripts, use b2v4 command"). For another it will remove some text
from MESSAGE which should be as short as possible - we find people tend
to ignore larger chunks of text at the end of pkg_add so best keep it
short and to the point. I think users can be expected to figure out
symlinks or shell aliases themselves too, so I'd go with just this for
MESSAGE:
The b2 CLI utility has been renamed to backblaze-b2 to avoid a conflict
with the Boost b2 utility.
- the idna dependency is listed upstream with
"idna~=3.4; platform_system == 'Java'" and doesn't seem to
be used in the code; is that actually needed?
With the first of those changes, and the secomnd if appropriate, it's
ok sthen.
