On Tue, Sep 10, 2024 at 11:54 AM Stuart Henderson <s...@spacehopper.org>
wrote:

> On 2024/09/09 23:00, aisha wrote:
> > On 24/09/09 10:26PM, Neel chakraborty wrote:
> > COMMENT =             zoxide is a smarter cd command
> >
> > > comment should not end with "."
>
> it shouldn't repeat the name of the package either.
>
> keeping the same basic description, just "smarter cd command" would be
> more like the usual style for COMMENT, but it would be better to briefly
> explain what it does than use the word "smarter" which is really unclear
> (and subjective).
>
> maybe something like "replacement for cd with history searching"?
>
> > post-install:
> >       ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide.1 ${PREFIX}/man/man1/
> >       ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-add.1 ${PREFIX}/man/man1/
> >       ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-import.1
> ${PREFIX}/man/man1/
> >       ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-init.1 ${PREFIX}/man/man1/
> >       ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-query.1
> ${PREFIX}/man/man1/
> >       ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-remove.1
> ${PREFIX}/man/man1/
>
> why not just "${INSTALL_MAN} ${WRKSRC}/man/man1/*.1 ${PREFIX}/man/man1/"?
> more efficient and doesn't need changing if another page is added in a
> future version.
>
> Thank you Stuart for your feedback, I have made the relevant changes to
the Makefile.
Fix attached.

Attachment: zoxide-0.9.4.tar.gz
Description: GNU Zip compressed data

Reply via email to