On 2024/09/09 23:00, aisha wrote:
> On 24/09/09 10:26PM, Neel chakraborty wrote:
> COMMENT = zoxide is a smarter cd command
>
> > comment should not end with "."
it shouldn't repeat the name of the package either.
keeping the same basic description, just "smarter cd command" would be
more like the usual style for COMMENT, but it would be better to briefly
explain what it does than use the word "smarter" which is really unclear
(and subjective).
maybe something like "replacement for cd with history searching"?
> post-install:
> ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide.1 ${PREFIX}/man/man1/
> ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-add.1 ${PREFIX}/man/man1/
> ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-import.1 ${PREFIX}/man/man1/
> ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-init.1 ${PREFIX}/man/man1/
> ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-query.1 ${PREFIX}/man/man1/
> ${INSTALL_MAN} ${WRKSRC}/man/man1/zoxide-remove.1 ${PREFIX}/man/man1/
why not just "${INSTALL_MAN} ${WRKSRC}/man/man1/*.1 ${PREFIX}/man/man1/"?
more efficient and doesn't need changing if another page is added in a
future version.
> Not 100% sure how much I like this command...
>
> > obsd-ports# zoxide init ksh
> > error: invalid value 'ksh' for '<SHELL>'
> > [possible values: bash, elvish, fish, nushell, posix, powershell, xonsh,
> > zsh]
> >
> > tip: a similar value exists: 'zsh'
> >
> > For more information, try '--help'.
..
> OK aisha if someone wants to import this.
I wrote a port for zoxide before (mostly because I wanted to see how
it integrated with the shell; overriding an important shell builtin with
a large third-party binary doesn't seem particularly smart to me) but I
couldn't get it to work with openbsd ksh either. I would have expected
the 'other posix shell' instructions to work but that was no good.
I haven't retried with this port, but unless that improves I don't
think it's really worth importing.
> fixed port attached.
btw you now have a mix of "VAR =<space><tab>" and "VAR =<tab>".
