On 2024/07/14 16:56, Denis Bodor wrote: > Hi ports! > > Attached is a port of libNFC > > libNFC is a library which allows userspace tools access to NFC > devices/readers (over serial, USB, PC/SC, etc). > > I decided to make PC/SC support a flavor because this library is usually > used directly with USB devices and very rarely with PC/SC, which induces > an often useless dependency. > > Build and run on amd64 without problems. > > Comments? Ok? > > -- > Denis
A few comments - I've attached an updated tgz addressing them. I can't test runtime myself, but that tweaked version would be ok with me to import. - The flavour name would be better as just "pcsc", however, for libraries it's usually a bad idea to use flavours. I would make a decision and either include pcsc-lite by default, or remove the flavour unless someone has a specific need for it. (As things are now, it's broken anyway, trying to use the flavour results in "configure: error: Unknow driver: pn53x_usbacr122_pcsc" due to a missing ,). - SHARED_LIBS versions should start at 0.0. - DESCR has a bit much "advertising style" blurb. Just talk about what the software does. - The share/examples directory shouldn't include the version number, just name it share/examples/nfc. libnfc.conf.sample should be installed into /etc/nfc via the @sample mechanism. - If NO_TEST is removed and you run "make test" there are no errors; in that situation we normally don't include NO_TEST, only if there are no tests and it errors out, or if tests are present but require extra dependencies. (Reasoning being that if tests are enabled in a later version we normally want them to run). Actually there are tests and we have the prerequisite dependency (cutter) but the autoconf scripts are not allowing this to be detected, probably due to a bug.
libnfc.tgz
Description: application/tar-gz
