On 2024/07/15 08:35, Landry Breuil wrote: > Le Sun, Jul 14, 2024 at 04:56:29PM +0200, Denis Bodor a écrit : > > Hi ports! > > > > Attached is a port of libNFC > > > > libNFC is a library which allows userspace tools access to NFC > > devices/readers (over serial, USB, PC/SC, etc). > > > > I decided to make PC/SC support a flavor because this library is usually > > used directly with USB devices and very rarely with PC/SC, which induces > > an often useless dependency. > > > > Build and run on amd64 without problems. > > > > Comments? Ok? > > looks good, minor nits: > > - you dont need to set PKGNAME when DISTNAME is set and has the same value > - you dont need to add libusb1 to LIB_DEPENDS since libusb-compat > depends on it. > > other than that, ok with me. > > Landry >
I have a few more issues, will reply a bit later.