On 2024/07/02 14:12, Kirill A. Korinsky wrote:
> Hi,
>
> Thanks for review.
Updated tgz is ok sthen@ if someone would like to import
(or, any OKs so I can commit)?
> On Tue, 02 Jul 2024 13:16:51 +0100,
> Stuart Henderson <s...@spacehopper.org> wrote:
> >
> > - I get a SEGV from make test, if that's expected (modernc.org sqlite
> > related perhaps) then a comment would be nice, maybe with NO_TEST
>
> Thanks, I forgot to add NO_TEST and reported it to upstream. Just did.
>
> > - Not sure it's worth patching in the port, but I ran into it during
> > testing so thought I'd mentoin - the usage text from running trdsql
> > has an example:
> > cat test.csv | trdsql -i csv -oltsv "SELECT c1,c2 FROM -"
> > that is incorrect, it needs to be
> > cat test.csv | trdsql -icsv -oltsv "SELECT c1,c2 FROM -"
> >
>
> I can't find an example with `-i csv´, where have you find it?
$ trdsql
trdsql - Execute SQL queries on CSV, LTSV, JSON, YAML and TBLN.
Usage
trdsql [OPTIONS] [SQL(SELECT...)]
[...snip...]
Input Formats:
-icsv CSV format for input.
-ig guess format from extension. (default "true")
-ijson JSON format for input.
-iltsv LTSV format for input.
[...snip...]
Examples:
$ trdsql "SELECT c1,c2 FROM test.csv"
$ trdsql -oltsv "SELECT c1,c2 FROM test.json::items"
$ cat test.csv | trdsql -i csv -oltsv "SELECT c1,c2 FROM -"
> And updated tgz which addressed remarks and diff of changes:
>
> diff --git textproc/trdsql/Makefile textproc/trdsql/Makefile
> index 27abaa6eba7..5da933dcefd 100644
> --- textproc/trdsql/Makefile
> +++ textproc/trdsql/Makefile
> @@ -1,5 +1,3 @@
> -ONLY_FOR_ARCHS = ${GO_ARCHS}
> -
> COMMENT = run SQL queries on CSV, LTSV, JSON, YAML and TBLN
>
> MODGO_MODNAME = github.com/noborus/trdsql
> @@ -7,7 +5,7 @@ MODGO_VERSION = v1.0.0
>
> DISTNAME = trdsql-${MODGO_VERSION}
>
> -CATEGORIES = textproc
> +CATEGORIES = textproc databases
>
> HOMEPAGE = https://noborus.github.io/trdsql/
>
> @@ -20,6 +18,13 @@ WANTLIB += c pthread
>
> MODULES = lang/go
>
> +# See: https://github.com/noborus/trdsql/issues/282
> +NO_TEST= Yes
> +
> +post-install:
> + ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/trdsql
> + ${INSTALL_DATA} ${WRKSRC}/README.md ${PREFIX}/share/doc/trdsql
> +
> .include "modules.inc"
>
> .include <bsd.port.mk>
> diff --git textproc/trdsql/pkg/DESCR textproc/trdsql/pkg/DESCR
> index 83fe2ae6805..c4923ff92e3 100644
> --- textproc/trdsql/pkg/DESCR
> +++ textproc/trdsql/pkg/DESCR
> @@ -3,3 +3,6 @@ YAML and TBLN files.
>
> This tool is similar to others such as q and textql, with a key
> distinction: it allows the use of PostgreSQL or MySQL syntax.
> +
> +For more information, see ${PREFIX}/share/doc/trdsql/README.md
> +or https://pkg.go.dev/github.com/noborus/trdsql
> diff --git textproc/trdsql/pkg/PLIST textproc/trdsql/pkg/PLIST
> index 800aeed983c..1c87ee13013 100644
> --- textproc/trdsql/pkg/PLIST
> +++ textproc/trdsql/pkg/PLIST
> @@ -1 +1,3 @@
> @bin bin/trdsql
> +share/doc/trdsql/
> +share/doc/trdsql/README.md
>
>
> --
> wbr, Kirill
