Looks like it could be handy. a few small nits:

- No need to set ONLY_FOR_ARCHS, that is handled by go.port.mk.
- I would add 'databases' to CATEGORIES.
- Though the formatting isn't brilliant in a terminal, it might be
useful to install README.md in ${PREFIX}/share/doc/trdsql.
Perhaps also mention https://pkg.go.dev/github.com/noborus/trdsql
in DESCR as it's a bit more useful than the doc in HOMEPAGE.

Others:

- I get a SEGV from make test, if that's expected (modernc.org sqlite
related perhaps) then a comment would be nice, maybe with NO_TEST
- Not sure it's worth patching in the port, but I ran into it during
testing so thought I'd mentoin - the usage text from running trdsql
has an example:
   cat test.csv | trdsql -i csv -oltsv "SELECT c1,c2 FROM -"
that is incorrect, it needs to be
   cat test.csv | trdsql -icsv -oltsv "SELECT c1,c2 FROM -"

On 2024/07/02 12:11, Kirill A. Korinsky wrote:
> ports@,
> 
> Just a reminded that I'd like to import it.
> 
> On Wed, 19 Jun 2024 11:59:52 +0100,
> Kirill A. Korinsky <kir...@korins.ky> wrote:
> > 
> > I'd like to suggest to import textproc/trdsql.
> > 
> > trdsql is a CLI tool which allows to run SQL query against CSV, LTSV, JSON,
> > YAML and TBLN files.
> > 
> > This tool is similar to others such as q and textql, with a key distinction:
> > it allows the use of PostgreSQL or MySQL syntax, and it supports not only
> > CSV and TSV formats, and a few other.
> > 
> > Tested on -current/amd64
> > 
> 
> -- 
> wbr, Kirill


Reply via email to