On Thu, Nov 23, 2023 at 05:43:07PM +0000, Stuart Henderson wrote: > when creating a tar, please "cd .." first and include the subdir in your > tar rather than dumping Makefile/distinfo etc in the current directory > > On 2023/11/23 11:59, Josh Rickmar wrote: > > Attached is a new port for FLINT. > > > > https://flintlib.org/ > > > > I was unsure if the .so handling in post-install is the preferred way > > to fix this up. I also have another version that patches configure.ac > > that seems to work just as well (by patching the constants to match > > the port's SHARED_LIBS, removing the install of the symlinks, and > > using major.minor for the full versioned name). > > the library should be created with the correct name as part of the build > rather than mv'ing afterwards. you often don't need to patch for that, > just set the right variables. for symlinks it's usually simpler to just > rm or @comment rather than patch. > > : V = 3.0.1 > : DISTNAME = flint-${V} > > V is only used once, so using it directly as flint-3.0.1 is preferred > > : CATEGORIES = devel > > this is definitely a candidate for math/ rather than the very-full devel/ > > : LIB_DEPENDS = devel/gmp devel/mpfr > > please list one per line > > : share/examples/flint/README.md > > better in doc > > : ===> Building for flint-3.0.1 > : mkdir -p build/generic_files > : CC generic_files/clz_tab.lo > : CC generic_files/exception.lo > : CC generic_files/fprintf.lo > : CC generic_files/fscanf.lo > [..] > > please patch to avoid hiding the compiler command-lines (unfortunately > upstream don't make it easy here; with many projects you can just set > a variable e.g. MAKE_FLAGS= V=1 or similar). as well as allowing > checking whether the build respects CFLAGS/CXXFLAGS/etc it can also be > useful in debugging build failures that show up on some systems but > not others. > > it takes forever to build, so let's set DPB_PROPERTIES=parallel too. > updated tgz attached. >
Thanks for the help/feedback. Good to know there's a better way to deal with those .so names and symlinks. I've noticed that it builds all of the objects twice: once to build the .so and again for the .a. I wonder if we could patch the build system to prevent this and improve the build time (seems like a patch that should hit upstream).
