ping Jun 11, 2023 21:43:17 Johannes Thyssen Tishman <li...@thyssentishman.com>:
> Hi Stuart, > >> - the Makefile comment about FindCairo.cmake is outdated/confusing > > Updated thank you. While I was there I removed the other post-extract > command as it was not really necessary. > >> - please drop those sprintf->snprintf patches, you can try sending >> them upstream if you like, there's not really a need for that in ports > > Done! I have a pull request open already for upstream. > >> - BUILD_DEPENDS looks wrong; don't list extract dependencies there, >> that's handled by ports infrastructure. what is gtk+4 for in there? > > Understood, thank you. Regarding gtk+4, nice catch I'm not sure how it > landed there. portcheck wants x11/gtk+4,-guic so I probably confused > something there. > >> - don't hardcode CMAKE_BUILD_TYPE, that's handled by the cmale module > > Got it :) > >> - any reason why you don't have COMPILER=base-clang ports-gcc? > > When compiling with gcc the build fails with undefined symbol errors. > Not sure why, but this doesn't happen with clang. > > Please find attached an updated tarball. Thanks for the feedback :) > > Kind regards, > Johannes > >> On 2023/05/26 09:30, Johannes Thyssen Tishman wrote: >>> Hi Stefan, >>> >>>> Looks good now. >>>> >>>> OK for import sdk@ >>> >>> Awesome, thanks for that. Please find attached the port with the >>> following last minute tweaks: >>> >>> - Formated DESCR based on your suggestions >>> - Updated DESCR to match description on solvespace's website >>> - Dropped Jerome KASPER from MAINTAINER as per his request >>> >>> Thanks again :) >>> >>> Kind regards, >>> >>> -- >>> Johannes Thyssen Tishman >>> https://thyssentishman.com>>>
