Hi Stefan,

Thanks for the feedback.

> I can confirm it's working now.

Glad to hear that :)

> Attached is the port again with some tweaks:
>
> * WANTLIB sorted
> * Some Makefile =<space><tab> fixes
> * Simplified post-extract
> * Copy FindCairo.cmake from FILESDIR instead of patching it in

Didn't know about the FILESDIR. It definitely makes more sense than the
patch, thanks.

> Reg. the patches: I prefer lines to be removed instead of commented.
> This makes the patch smaller and better readable. But it's a matter
> of taste, so I didn't change it.

We had them commented as some of them had a explanation comment as well.
I've now removed the lines instead and put the explanations at the top
of the file as suggested by the porting guide.

> Please double check if you want arc4random here or srand_deterministic
> or not touch it at all.

Yeah, seems like upstream want determinism so we dropped the patches.

Some extra changes on the attached port:

* Uncommented find_package(Backtrace) since it works just fine
* Restored GETTEXT to XGETTEXT as the rename seems unnecessary
* WANTLIB += execinfo as suggested by port-lib-depends-check

Further comments, OK to import or more feedback welcome.

Kind regards,

--
Johannes Thyssen Tishman
https://thyssentishman.com

Attachment: solvespace.tar.gz
Description: application/tar-gz

Reply via email to