Sven M. Hallberg on Mon, Mar 20 2023:
> Indeed, gnetlist-legacy/tests/stack_1-geda.sch does not exist; the file
> is called stack_1.sch. No idea, what's going on here.
Found this one, too. Something weird in their shell escaping.
Patch below also adds fixes for two glibc-style includes of <alloca.h>.
With that, the test suite passes for me. :)
Will follow up with another iteration after working in Stuart's replies.
-p
Index: cad/geda-gaf/patches/patch-gnetlist-legacy_tests_run-test
===================================================================
RCS file: cad/geda-gaf/patches/patch-gnetlist-legacy_tests_run-test
diff -N cad/geda-gaf/patches/patch-gnetlist-legacy_tests_run-test
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ cad/geda-gaf/patches/patch-gnetlist-legacy_tests_run-test 20 Mar 2023
13:04:58 -0000
@@ -0,0 +1,14 @@
+Avoid (erroneous) backslash escapes by using extended REs.
+
+Index: gnetlist-legacy/tests/run-test
+--- gnetlist-legacy/tests/run-test.orig
++++ gnetlist-legacy/tests/run-test
+@@ -2,7 +2,7 @@
+
+ ref="$1"
+ tmp="`echo "x$1" | sed -e 's:.*/tests/::' -e 's:\\.out$::' -e 's:^x\\./::'`"
+-stem="`echo "${tmp}" | sed -e 's:-spice-.*:@@@:' -e
's:\\(-[^-@]*\\|@@@\\)$::'`"
++stem="`echo "${tmp}" | sed -E -e 's:-spice-.*:@@@:' -e 's:(-[^-@]*|@@@)$::'`"
+ backend="`echo "${tmp}" | sed -e "s:^${stem}-::"`"
+
+ GNETLIST="${abs_top_builddir}/gnetlist-legacy/src/gnetlist-legacy"
Index: cad/geda-gaf/patches/patch-xorn_tests_storage_normalize_c
===================================================================
RCS file: cad/geda-gaf/patches/patch-xorn_tests_storage_normalize_c
diff -N cad/geda-gaf/patches/patch-xorn_tests_storage_normalize_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ cad/geda-gaf/patches/patch-xorn_tests_storage_normalize_c 20 Mar 2023
13:33:33 -0000
@@ -0,0 +1,14 @@
+alloca.h is a glibc thing.
+
+Index: xorn/tests/storage/normalize.c
+--- xorn/tests/storage/normalize.c.orig
++++ xorn/tests/storage/normalize.c
+@@ -15,7 +15,7 @@
+ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */
+
+ #include <xornstorage.h>
+-#include <alloca.h>
++#include <stdlib.h> /* alloca() */
+ #include <assert.h>
+ #include <string.h>
+
Index: cad/geda-gaf/patches/patch-xorn_tests_storage_validate_c
===================================================================
RCS file: cad/geda-gaf/patches/patch-xorn_tests_storage_validate_c
diff -N cad/geda-gaf/patches/patch-xorn_tests_storage_validate_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ cad/geda-gaf/patches/patch-xorn_tests_storage_validate_c 20 Mar 2023
13:33:33 -0000
@@ -0,0 +1,14 @@
+alloca.h is a glibc thing.
+
+Index: xorn/tests/storage/validate.c
+--- xorn/tests/storage/validate.c.orig
++++ xorn/tests/storage/validate.c
+@@ -15,7 +15,7 @@
+ Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */
+
+ #include <xornstorage.h>
+-#include <alloca.h>
++#include <stdlib.h> /* alloca() */
+ #include <assert.h>
+ #include <math.h>
+ #include <string.h>
