On 2022/11/13 09:59, Omar Polo wrote:
> On 2022/11/12 14:53:37 +0100, Caspar Schutijser <cas...@schutijser.com> wrote:
> > Hi,
> > 
> > On Thu, Nov 10, 2022 at 07:25:44PM +0100, Tim van der Molen wrote:
> > > Hi,
> > > 
> > > Attached is a port for nostt.
> > > 
> > > nostt is a command-line NOS Teletekst reader. It supports color and has
> > > an interactive mode. NOS Teletekst is the teletext service of the Dutch
> > > public broadcaster NOS.
> > > 
> > > https://github.com/sjmulder/nostt
> > > 
> > > Comments? OK?
> > 
> > Tested on amd64, works fine here. The port looks good to me, but I'm
> > wondering about the 'CC="${CC}"' line. When I removed that, the port
> > built fine as well. Can you explain why that is necessary? Am I missing
> > something?
> 
> yep, setting CC in MAKE_ENV is unnecessary, although it doesn't harm.
> There are a few trailing whitespaces in the Makefile, otherwise it's
> fine for me too.

tim@ was right the first time, MAKE_ENV in CC is needed.

Ports builds are supposed to use the compiler set by CC.
Compare "make CC=clang" with/without CC in MAKE_ENV.

Reply via email to