On Sun, Nov 13, 2022 at 09:59:24AM +0100, Omar Polo wrote:
> On 2022/11/12 14:53:37 +0100, Caspar Schutijser <cas...@schutijser.com> wrote:
> > Hi,
> >
> > On Thu, Nov 10, 2022 at 07:25:44PM +0100, Tim van der Molen wrote:
> > > Hi,
> > >
> > > Attached is a port for nostt.
> > >
> > > nostt is a command-line NOS Teletekst reader. It supports color and has
> > > an interactive mode. NOS Teletekst is the teletext service of the Dutch
> > > public broadcaster NOS.
> > >
> > > https://github.com/sjmulder/nostt
> > >
> > > Comments? OK?
> >
> > Tested on amd64, works fine here. The port looks good to me, but I'm
> > wondering about the 'CC="${CC}"' line. When I removed that, the port
> > built fine as well. Can you explain why that is necessary? Am I missing
> > something?
>
> yep, setting CC in MAKE_ENV is unnecessary, although it doesn't harm.
Alright, thank you for verifying that.
With all the nits fixed it's OK caspar@
> There are a few trailing whitespaces in the Makefile, otherwise it's
> fine for me too.
>
> I guess we could use TEST_TARGET=check and drop NO_TEST, but it needs
> an internet connection anyway so i think it's fine as-is.
>
>
> --- Makefile.orig Sun Nov 13 09:49:47 2022
> +++ Makefile Sun Nov 13 09:54:32 2022
> @@ -16,9 +16,8 @@
>
> LIB_DEPENDS = devel/json-c \
> net/curl
> -
> -MAKE_ENV = CC="${CC}" \
> - CPPFLAGS="-I${LOCALBASE}/include" \
> +
> +MAKE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \
> LDFLAGS="-L${LOCALBASE}/lib"
> FAKE_FLAGS = DESTDIR=
>
>
