On 2022/10/05 17:44:49 +0200, "Thim Cederlund" <t...@cederlund.de> wrote:
> On Tue Oct 4, 2022 at 11:20 AM CEST, Omar Polo wrote:
> > I think we can live without a copy of the GPL, i don't think it should
> > be installed.
> >
> > upstream makefile seems to have some support for renaming. Setting
> > NAME=dragon-drop as FAKE_FLAGS seems to do it.
>
> Very well, it wasn't clear to me if we always have to make sure that a copy of
> the license gets installed if provided so I went with it, but now I know.
IANAL but i think it depends on the license. GPL and friends don't
require it as far as i know while at least in theory the various BSD
licenses require the copyright line to be shipped ("... provided that
the above copyright notice and this permission notice appear in all
copies".) Keep in mind thought that only rarely the commonly used
LICENSE file contains the whole story, and often applications have
their own ways to respect these licensing issue.
> The custom target was also there in case upstream decides to drop the NAME
> flag for any reason, but sure, the Makefile it a bit tidier without it :)
we'll find a way to deal with it if/when it happens :)
> > nitpick: i'd consistently use += for WANTLIB, like
> > `make port-lib-depends-check' outputs.
>
> Actually it _is_ the output of make ports-lib-depends-check. Weirdly enough
> it didn't append the libraries in the first line. But fine, I'll remember to
> keep an eye for any incosistencies in the future :)
this is strange! i think i have a decently up-to-date tree and
check-lib-depends seems to work just as a usual:
% make port-lib-depends-check
Missing: [...]
WANTLIB += atk-1.0 c cairo cairo-gobject gdk-3 gdk_pixbuf-2.0
WANTLIB += gio-2.0 glib-2.0 gobject-2.0 gtk-3 harfbuzz intl pango-1.0
WANTLIB += pangocairo-1.0 pthread
*** Error 1 in target 'port-lib-depends-check' (ignored)
> > Briefly tested, seems to work just fine, thanks!
> >
> > Here's a tweaked tarball that's OK op@ to import
>
> Thank you Omar :) Does anyone want to import it? (I've reattached @op's copy)
>
> Best Regards,
>
> Thim Cederlund
