On Tue Oct 4, 2022 at 11:20 AM CEST, Omar Polo wrote: > I think we can live without a copy of the GPL, i don't think it should > be installed. > > upstream makefile seems to have some support for renaming. Setting > NAME=dragon-drop as FAKE_FLAGS seems to do it.
Very well, it wasn't clear to me if we always have to make sure that a copy of the license gets installed if provided so I went with it, but now I know. The custom target was also there in case upstream decides to drop the NAME flag for any reason, but sure, the Makefile it a bit tidier without it :) > nitpick: i'd consistently use += for WANTLIB, like > `make port-lib-depends-check' outputs. Actually it _is_ the output of make ports-lib-depends-check. Weirdly enough it didn't append the libraries in the first line. But fine, I'll remember to keep an eye for any incosistencies in the future :) > Briefly tested, seems to work just fine, thanks! > > Here's a tweaked tarball that's OK op@ to import Thank you Omar :) Does anyone want to import it? (I've reattached @op's copy) Best Regards, Thim Cederlund
dragon-drop.tar.gz
Description: application/gzip
