On 5/31/2022 10:39 PM, Brian Callahan wrote: > Hello again -- > > On 5/29/2022 2:37 PM, Brian Callahan wrote: >> Hello -- >> >> I am away for the US holiday. I'll be back tomorrow evening and I will >> check this over then. >> > > I've been able to look this over now. Attached is an improved diff that > updates the DESCR with the meaningful changes from your original diff. > > I also discovered that your original diff failed the build test--or, at > least, you didn't report that (at least some) dependent ports will not > build with this update. For example, the build for graphics/drawpile > fails because an integer was changed to an enum: > https://github.com/drawpile/Drawpile/pull/925/files > > Upstream claims there is no ABI breakage but apparently that is only > true for C, not C++, so perhaps a major bump is in order to be safe > (attached diff does this). > > I have only build tested drawpile so far. The others are being built > now. I'll send an update for drawpile in a separate email and send > updates for any other dependent ports that need it in their own separate > emails. > > ~Brian
Returning to this, I've been able to build test all dependent ports. There were two ports that required tweaks for the new libmicrohttpd: drawpile and collectd. I've sent update diffs for both of them to be used with the new libmicrohttpd diff sent in the previous email to this thread. In the future, please at least build test all the dependent ports of a library; it really does help speed up the testing and review process. ~Brian
