I haven't tested yet but that looks good to me now.
For more about shared library versions, see
https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs

On 2022/05/13 14:40, Martin Ziemer wrote:
> Am Fri, May 13, 2022 at 12:50:19PM +0100 schrieb Stuart Henderson:
> > On 2022/05/13 13:33, Omar Polo wrote:
> > > Martin Ziemer <hor...@horrad.de> wrote:
> > > > Am Thu, May 05, 2022 at 08:16:28AM +0200 schrieb Martin Ziemer:
> > > > > This patch updates twolame from 0.3.13 to 0.4.0. 
> > > Haven't had the time to test it yet nor look deeply, but I think the
> > > SHARED_LIBS needs some bumping.  excerpt from /usr/src/lib/check_sym:
> > Major bump for that, for sure.
> > Need to make sure it doesn't break gstreamer1/plugins-good too
> Just learned something new! (I just copied the contents of shared_libs.log)
> 
> Tested twolame on amd64 and built the following ports after bump to 1.0:
>   multimedia/imagination
>   telephony/baresip/baresip
>   audio/sox
>   multimedia/transcode
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/twolame/Makefile,v
> retrieving revision 1.8
> diff -u -p -r1.8 Makefile
> --- Makefile  1 Apr 2022 17:18:16 -0000       1.8
> +++ Makefile  13 May 2022 12:30:58 -0000
> @@ -1,12 +1,13 @@
>  COMMENT=     optimised MPEG Audio Layer 2 (MP2) encoder
>  
> -DISTNAME=    twolame-0.3.13
> -REVISION=    2
> -SHARED_LIBS +=  twolame              0.0      # 0.0
> +DISTNAME=    twolame-0.4.0
> +SHARED_LIBS +=  twolame              1.0      # 0.0
>  
>  CATEGORIES=  audio
>  
>  HOMEPAGE=    http://www.twolame.org/
> +
> +MAINTAINER = Martin Ziemer <hor...@horrad.de>
>  
>  # LGPLv2.1+
>  PERMIT_PACKAGE=      Yes
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/audio/twolame/distinfo,v
> retrieving revision 1.2
> diff -u -p -r1.2 distinfo
> --- distinfo  18 Jan 2015 03:12:49 -0000      1.2
> +++ distinfo  13 May 2022 12:30:58 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (twolame-0.3.13.tar.gz) = mPMy9IlR9H8j9w/QN5Rjr/fX+ybwfh4k5C3e8izGESo=
> -SIZE (twolame-0.3.13.tar.gz) = 660415
> +SHA256 (twolame-0.4.0.tar.gz) = zDVCT2AZqIxvUlcLY+G69Q9iljo+rFKgOoALsHDXyH0=
> +SIZE (twolame-0.4.0.tar.gz) = 890908
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/audio/twolame/pkg/PLIST,v
> retrieving revision 1.3
> diff -u -p -r1.3 PLIST
> --- pkg/PLIST 11 Mar 2022 18:20:34 -0000      1.3
> +++ pkg/PLIST 13 May 2022 12:30:58 -0000
> @@ -1,30 +1,15 @@
>  @bin bin/twolame
>  include/twolame.h
> -lib/libtwolame.a
> +@static-lib lib/libtwolame.a
>  lib/libtwolame.la
>  @lib lib/libtwolame.so.${LIBtwolame_VERSION}
>  lib/pkgconfig/twolame.pc
>  @man man/man1/twolame.1
>  share/doc/twolame/
> +share/doc/twolame/AUTHORS
> +share/doc/twolame/COPYING
> +share/doc/twolame/NEWS
> +share/doc/twolame/README
>  share/doc/twolame/api.txt
> -share/doc/twolame/html/
> -share/doc/twolame/html/api.html
> -share/doc/twolame/html/authors.html
> -share/doc/twolame/html/changelog.html
> -share/doc/twolame/html/doxygen.css
> -share/doc/twolame/html/doxygen.png
> -share/doc/twolame/html/index.html
> -share/doc/twolame/html/nav_f.png
> -share/doc/twolame/html/nav_h.png
> -share/doc/twolame/html/psycho.html
> -share/doc/twolame/html/readme.html
> -share/doc/twolame/html/tabs.css
> -share/doc/twolame/html/todo.html
> -share/doc/twolame/html/twolame-manpage.css
> -share/doc/twolame/html/twolame.1.html
> -share/doc/twolame/html/twolame.css
> -share/doc/twolame/html/twolame_8h.html
> -share/doc/twolame/html/twolame_8h_source.html
> -share/doc/twolame/html/vbr.html
>  share/doc/twolame/psycho.txt
>  share/doc/twolame/vbr.txt
> 

Reply via email to