Martin Ziemer <hor...@horrad.de> wrote:
> Am Thu, May 05, 2022 at 08:16:28AM +0200 schrieb Martin Ziemer:
> > This patch updates twolame from 0.3.13 to 0.4.0.
> >
> > Since i saw there is no maintainer, i also added myself as maintainer.
> >
> > Tested on two amd64 systems and built sox with the new version.
Haven't had the time to test it yet nor look deeply, but I think the
SHARED_LIBS needs some bumping. excerpt from /usr/src/lib/check_sym:
/usr/local/lib/libtwolame.so.0.0 -->
/usr/ports/pobj/twolame-0.4.0/fake-amd64/usr/local/lib/libtwolame.so.0.0
Dynamic export changes:
added:
twolame_a_bit_allocation
twolame_ath_db
twolame_ath_energy
twolame_ath_freq2bark
twolame_available_bits
twolame_bits_for_nonoise
twolame_buffer_deinit
twolame_buffer_init
...
removed:
a_bit_allocation
ath_db
ath_energy
ath_freq2bark
available_bits
bits_for_nonoise
buffer_deinit
buffer_init
combine_lr
crc_writeheader
dab_crc_calc
dab_crc_update
do_energy_levels
encode_init
find_sf_max
get_required_energy_bits
init_bit_allocation
init_subband
main_bit_allocation
psycho_0
psycho_0_deinit
psycho_1
psycho_1_deinit
psycho_1_fft
psycho_2
psycho_2_deinit
psycho_2_fft
psycho_2_init
psycho_3
psycho_3_deinit
psycho_4
psycho_4_deinit
psycho_n1
scalefactor_calc
sf_transmission_pattern
slots
subband_quantization
vbr_bit_allocation
window_filter_subband
write_bit_alloc
write_header
write_samples
write_scalefactors
so this needs at minimum a minor bump, and if the removed symbols were
effectively public a major one.
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/audio/twolame/Makefile,v
> retrieving revision 1.8
> diff -u -p -r1.8 Makefile
> --- Makefile 1 Apr 2022 17:18:16 -0000 1.8
> +++ Makefile 26 Apr 2022 13:30:10 -0000
> @@ -1,12 +1,13 @@
> COMMENT= optimised MPEG Audio Layer 2 (MP2) encoder
>
> -DISTNAME= twolame-0.3.13
> -REVISION= 2
> +DISTNAME= twolame-0.4.0
> SHARED_LIBS += twolame 0.0 # 0.0
>
> CATEGORIES= audio
>
> HOMEPAGE= http://www.twolame.org/
> +
> +MAINTAINER = Martin Ziemer <hor...@horrad.de>
>
> # LGPLv2.1+
> PERMIT_PACKAGE= Yes
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/audio/twolame/distinfo,v
> retrieving revision 1.2
> diff -u -p -r1.2 distinfo
> --- distinfo 18 Jan 2015 03:12:49 -0000 1.2
> +++ distinfo 26 Apr 2022 13:30:10 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (twolame-0.3.13.tar.gz) = mPMy9IlR9H8j9w/QN5Rjr/fX+ybwfh4k5C3e8izGESo=
> -SIZE (twolame-0.3.13.tar.gz) = 660415
> +SHA256 (twolame-0.4.0.tar.gz) = zDVCT2AZqIxvUlcLY+G69Q9iljo+rFKgOoALsHDXyH0=
> +SIZE (twolame-0.4.0.tar.gz) = 890908
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/audio/twolame/pkg/PLIST,v
> retrieving revision 1.3
> diff -u -p -r1.3 PLIST
> --- pkg/PLIST 11 Mar 2022 18:20:34 -0000 1.3
> +++ pkg/PLIST 26 Apr 2022 13:30:10 -0000
> @@ -1,30 +1,15 @@
> @bin bin/twolame
> include/twolame.h
> -lib/libtwolame.a
> +@static-lib lib/libtwolame.a
> lib/libtwolame.la
> @lib lib/libtwolame.so.${LIBtwolame_VERSION}
> lib/pkgconfig/twolame.pc
> @man man/man1/twolame.1
> share/doc/twolame/
> +share/doc/twolame/AUTHORS
> +share/doc/twolame/COPYING
> +share/doc/twolame/NEWS
> +share/doc/twolame/README
> share/doc/twolame/api.txt
> -share/doc/twolame/html/
> -share/doc/twolame/html/api.html
> -share/doc/twolame/html/authors.html
> -share/doc/twolame/html/changelog.html
> -share/doc/twolame/html/doxygen.css
> -share/doc/twolame/html/doxygen.png
> -share/doc/twolame/html/index.html
> -share/doc/twolame/html/nav_f.png
> -share/doc/twolame/html/nav_h.png
> -share/doc/twolame/html/psycho.html
> -share/doc/twolame/html/readme.html
> -share/doc/twolame/html/tabs.css
> -share/doc/twolame/html/todo.html
> -share/doc/twolame/html/twolame-manpage.css
> -share/doc/twolame/html/twolame.1.html
> -share/doc/twolame/html/twolame.css
> -share/doc/twolame/html/twolame_8h.html
> -share/doc/twolame/html/twolame_8h_source.html
> -share/doc/twolame/html/vbr.html
> share/doc/twolame/psycho.txt
> share/doc/twolame/vbr.txt
