David Demelier <mark...@malikania.fr> wrote: > On Wed, 2022-05-04 at 11:33 +0200, Omar Polo wrote: > > I'd avoid rolling a custom do-install if possible: it can get > > out-of-sync with updates and it's difficult to notice. gmake would > > be a > > build-only dependency anyway, not something the users needs to have > > installed in order to use this package. > > Yeah I had troubles using the upstream Makefile because of the DESTDIR > use, it didn't work without the FAKE_FLAGS macro. > > > Here's a diff on top of your makefile. (I'm setting PREFIX to > > TRUEPREFIX instead of setting an empty DESTDIR because the port' > > makefile generates the icons cache if DESTDIR is empty.) With the > > tabs > > vs. spaces thing mentioned by landry@ fixed I'm ok too :) > > The problem with broken tabs (i.e. used for alignment rather than > leading indents) is that they are displayed incorrectly when not set to > the original size (8 in our case). But since it's already present in > the ports tree I'll change that. > > See updated v2 attached. > > Thanks for feedback.
imported, thanks :)
