David Demelier <mark...@malikania.fr> wrote:
> Hi,
>
> This is a new port for a rich and modern papirus icon theme. It's my
> first submission, *any* comment is welcome.
>
> https://github.com/PapirusDevelopmentTeam/papirus-icon-theme
I'd avoid rolling a custom do-install if possible: it can get
out-of-sync with updates and it's difficult to notice. gmake would be a
build-only dependency anyway, not something the users needs to have
installed in order to use this package.
Here's a diff on top of your makefile. (I'm setting PREFIX to
TRUEPREFIX instead of setting an empty DESTDIR because the port'
makefile generates the icons cache if DESTDIR is empty.) With the tabs
vs. spaces thing mentioned by landry@ fixed I'm ok too :)
--- /tmp/papirus-icon-theme/Makefile Wed May 4 08:34:12 2022
+++ Makefile Wed May 4 09:22:52 2022
@@ -15,11 +15,8 @@
NO_BUILD= yes
RUN_DEPENDS= x11/gtk+3,-guic
-# avoid GNU make dependency
-do-install:
- ${INSTALL_DATA_DIR} ${PREFIX}/share/icons
-.for t in Papirus Papirus-Dark Papirus-Light ePapirus ePapirus-Dark
- cp -R ${WRKBUILD}/${t} ${PREFIX}/share/icons/${t}
-.endfor
+USE_GMAKE= Yes
+
+FAKE_FLAGS= PREFIX="${TRUEPREFIX}"
.include <bsd.port.mk>
