On Thu, Mar 03 2022, aisha <openbsd.po...@aisha.cc> wrote: > On 22/03/03 03:54PM, Stuart Henderson wrote: >> On 2022/03/03 10:45, aisha wrote: >> > I've attached the port with the tight version dependency suggested by >> > Jeremie. >> > Thanks for that. >> >> Needs NO_TEST=Yes,
Hmm, make test succeeds on my machine, even though there is no testsuite. In that case we don't set NO_TEST=Yes, since a subsequent update could bring tests. I will drop this line unless there is a reason to keep it. >> and the empty line in DESCR should be removed, >> probably better to reformat while there, e.g. >> >> ----- >> Python bindings for controlling and probing the Knot DNS server. >> These bindings provide an interface similar to knotc(8) and replies >> via JSON for easy parsing. >> ----- >> >> With those changes I'm OK with importing >> > > Done, thanks! Regarding py-libknot, I will include a patch to strip the libknot.so major version, else the resulting package would still be broken. It seems that you removed the MAINTAINER line, why? I would suggest that you keep it (I see no reason to be listed as a co-maintainer). Regarding knot, > Aisha > > diff --git a/net/knot/Makefile b/net/knot/Makefile > index 34b8da26a8a..d48f2eebd12 100644 > --- a/net/knot/Makefile > +++ b/net/knot/Makefile > @@ -2,6 +2,7 @@ > > COMMENT = authoritative DNS server > > +# bump net/py-libknot when bumping this > DISTNAME = knot-3.1.6 > > SHARED_LIBS += dnssec 3.1 # .8.0 > @@ -12,7 +13,8 @@ CATEGORIES = net > > HOMEPAGE = https://www.knot-dns.cz/ > > -MAINTAINER = Jeremie Courreges-Anglas <j...@wxcvbn.org> > +MAINTAINER = Jeremie Courreges-Anglas <j...@wxcvbn.org> \ > + Aisha Tammy <open...@aisha.cc> Changing MAINTAINER affects the resulting package, thus the change needs a bump. With no bump, make package would spot this and error out. I'll include that REVISION bump too, no need to resend. > > # GPLv3+ > PERMIT_PACKAGE = Yes > > -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
