Steven Mestdagh wrote on Mon, Apr 23, 2007 at 08:06:53AM +0200:
> Ingo Schwarze [2007-04-23, 00:00:58]:
>
>> COMMENT
>> jabber server, original implementation in C/C++
> 
> it looks like configure does not test for snprintf, and it decides to
> compile its own version. can you avoid that and use the function in libc?

Yes, that seems possible.  Thanks for the suggestion!

The updated tarball contains two additional patches:
  patch-jabberd_lib_Makefile_in (to leave snprintf.o out of libjabberd)
  patch-jabberd_lib_jabberdlib_h (to not alias snprintf to ap_snprintf)
The attached tarball is also available at
  http://www.studis.de/Software/jabberd14-1.6.0b4.tgz

Additional tests done include (all on i386-current):
 - all flavor combinations still compile, install and deinstall
 - the server still appears to be working with filespool and mysql
   storage (postgresql not retested)
 - changes to the output of `make install` are:
    * snprintf.lo and snprintf.o are not created any more
    * snprintf.lo is no more used for libjabberd.la
    * snprintf.o is no more included in libjabberd.{a,so.1.0}
    * no other changes
 - binary changes (checked using nm):
    * bin/jabberd14 now has "U snprintf" instead of "U ap_snprintf"
    * lib/libjabberd.so.1.0 now has "U snprintf" and "U vsnprintf",
      but lost "F snprintf.c", "T ap_snprintf", "T ap_vsnprintf",
      "U modf", "d low_digits.1", "d upper_digits.2", one of two
      "b buf.0" and several local text segment symbols.
    * I did not check the other library files in detail.

I think all this looks reasonable.

Attachment: jabberd14-1.6.0b4.tgz
Description: application/tar-gz

Reply via email to