2007/4/25, steven mestdagh <[EMAIL PROTECTED]>:
Ingo Schwarze [2007-04-24, 01:29:52]:
> >> jabber server, original implementation in C/C++
> >
> > it looks like configure does not test for snprintf, and it decides to
> > compile its own version. can you avoid that and use the function in libc?
>
> Yes, that seems possible.  Thanks for the suggestion!
>
> The updated tarball contains two additional patches:
>   patch-jabberd_lib_Makefile_in (to leave snprintf.o out of libjabberd)
>   patch-jabberd_lib_jabberdlib_h (to not alias snprintf to ap_snprintf)

that works, but it's probably more interesting to fix configure.ac to
check for snprintf/vsnprintf, since snprintf.c and jabberdlib.h already
have the necessary #if !defined(HAVE_SNPRINTF) etc. such a fix will be
easier to get included upstream, and the port will be easier for you to
maintain.

True, so I want to step in now and provide this updated version of the
'b3' version Ingo posted initially. This version patches configure.ac
to make sure HAVE_SNPRINTF and HAVE_VSNPRINTF  will be defined.  I
also changed CONFIGURE_STYLE=gnu to autoconf and made sure autoconf
2.60 is being used.

I am not sure this change is complete now so please review.
It still works fine on 4.0-STABLE anyway :-)

Wijnand

Attachment: jabberd14-1.6.0b5.tgz
Description: GNU Zip compressed data

Reply via email to