On 2021/08/26 17:47, Florian Viehweger wrote:
> Am Thu, 26 Aug 2021 12:55:29 +0100
> schrieb Stuart Henderson <[email protected]>:
>
> > On 2021/08/26 12:39, Florian Viehweger wrote:
> > > Hi,
> > >
> > > I'm in the process of revising my submitted update to profanity to
> > > use libstrophe instead of libmesode.
> > >
> > > The reason is that libmesode is deprecated upstream and libstrophe
> > > should be used.
> > >
> > > libstrophe: portcheck, 'make lib-depends-check' and 'make tests' are
> > > happy.
> > > I've removed the patch, because libstrophe got LibreSSL support in
> > > 0.10.0.
> >
> > libstrophe is not linked to the build in net/Makefile, that needs
> > doing too.
>
> That makes everything clear. After I sent the mail, I've discovered
> that working in /usr/ports/net/... works.
>
> > libmesode is then an orphan and it should probably be removed too.
>
> I've removed libmesode in net/Makefile. Is that sufficient, or should
> all individual files of libmesode marked as deleted?
Actually it's probably better to add "@pkgpath net/libmesode" to
libstrophe's PLIST, and add an entry to devel/quirks to handle the
new name. That way the old orphaned package is "merged" into the new
one so the user doesn't get a "could not find update" message.
> > ...
> >
> > Maybe working on a copy of the port rather than the actual one in
> > /usr/ports/net/libstrophe?
>
> Yes, I've always work in /usr/ports/mystuff/... and I never had a
> problem with it. It probably failed this time because libstrophe was
> marked as orphaned.
>
> I started working with copies in /usr/ports/mystuff after a workshop
> from bcallah@ on youtube[1].
It's because the library version was bumped, by default ports looks in
/usr/ports for dependency information so it finds the old information.
If you're working with copies in mystuff often you can set PORTSDIR_PATH
differently (default is ${PORTSDIR}:${PORTSDIR}/mystuff, sometimes it's
helpful to use ${PORTSDIR}/mystuff:${PORTSDIR} but then you will need to
get good at clearing already-committed/abandoned things in mystuff).
You can set that in mk.conf.
> libstrophe: portcheck complains that patches is empty and should be
> removed. Is 'cvs rm patches' after deleting the folder sufficient? I
> was under the impression that 'cvs rm' only deals with files?
Ignore that from portcheck, you can't rm a directory with cvs. The most
you can do is empty it of files, then cvs up -P will remove them later.
> Thank you for your help. I will submit an updated diff later tonight.
>
> So far everything works as expected.
>
>
> [1] https://www.youtube.com/watch?v=z_TnemhzbXQ
>
> --
> greetings,
>
> Florian Viehweger
>
