Since ~4 years I've received reports of emacs hanging in certain
situations, without a good hint about what was wrong.

  https://marc.info/?l=openbsd-ports&m=150996114220295&w=2
  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29170

Yesterday evening Gregoire wanted to nail down this bug and after
refreshing our memories of this problem we tried disabling the
broken-SIGIO-workaround contained in configure.  This workaround was
previously introduced by mikeb@ in 2011.  I hope that this workaround is
currently doing more harm than good, and that ditching it will fix the
various hangs reported in the few last years.

So folks (cc'd or not), please test this and report back.


Index: Makefile
===================================================================
RCS file: /d/cvs/ports/editors/emacs/Makefile,v
retrieving revision 1.100
diff -u -p -r1.100 Makefile
--- Makefile    13 Jul 2021 08:37:57 -0000      1.100
+++ Makefile    13 Jul 2021 23:37:24 -0000
@@ -4,7 +4,7 @@ COMMENT=                GNU editor: extensible, custom
 
 VERSION=               27.2
 DISTNAME=              emacs-${VERSION}
-REVISION=              0
+REVISION=              1
 
 CATEGORIES=            editors
 
Index: patches/patch-configure
===================================================================
RCS file: /d/cvs/ports/editors/emacs/patches/patch-configure,v
retrieving revision 1.20
diff -u -p -r1.20 patch-configure
--- patches/patch-configure     23 Aug 2020 09:55:01 -0000      1.20
+++ patches/patch-configure     14 Jul 2021 17:45:18 -0000
@@ -1,11 +1,27 @@
 $OpenBSD: patch-configure,v 1.20 2020/08/23 09:55:01 jca Exp $
 
+Don't disable SIGIO, it looks like an old workaround and it's suspected
+to be harmful.
+  https://marc.info/?l=openbsd-ports&m=150996114220295&w=2
+  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29170
+Introduced in:
+  https://marc.info/?l=openbsd-ports&m=130019184729434&w=2
+
 Use posix_openpt(3).
 https://debbugs.gnu.org/cgi/bugreport.cgi?bug=42059
 
 Index: configure
 --- configure.orig
 +++ configure
+@@ -19578,7 +19578,7 @@ esac
+ emacs_broken_SIGIO=no
+ 
+ case $opsys in
+-    hpux* | nacl | openbsd | sol2* | unixware )
++    hpux* | nacl | sol2* | unixware )
+     emacs_broken_SIGIO=yes
+     ;;
+ 
 @@ -19668,12 +19668,12 @@ case $opsys in
  
      ;;


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to