broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed.
The highlight isn't using Plasma theme anymore F7118110: Screenshot_20190730_084841.png <https://phabricator.kde.org/F7118110> The layout explodes for long category names, they should be elided. F7118127: Screenshot_20190730_085343.png <https://phabricator.kde.org/F7118127> The tooltips look quite bad and crammed because as I said they're not separate windows anymore. Also, they show up immediately instead of after a delay. Clicking results doesn't do anything now, and there can now be both a highlight following the mouse and a selection following the keyboard. INLINE COMMENTS > ResultDelegate.qml:233 > + if (index === 0) { // Shift+Return will invoke first > action > + text = i18ndc("milou", "placeholder is action e.g. > run in terminal, in parenthesis is shortcut", "%1 (Shift+Return)", text) > + } QQC2 tooltip doesn't seem to handle mnemonics, leading to text like "Run in &Terminal" > apol wrote in ResultDelegate.qml:142 > There's no separator svg. you suggest creating a new one? Use whatever the `PlasmaComponents.ListItem` uses REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D22540 To: apol, #plasma, broulik Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
