broulik added inline comments.
INLINE COMMENTS
> ResultDelegate.qml:138
>
> - width: resultDelegate.categoryWidth - units.largeSpacing
> + // fake pressed look
> + highlighted: ListView.isCurrentItem
Move that comment to where it belongs
> ResultDelegate.qml:142
> +
> + Rectangle { //Separator
> anchors {
This should be a `Svg` from the Plasma Theme
> ResultDelegate.qml:168
> + color: theme.textColor
> + opacity: 0.7
>
Where does that random `0.7` come from?
> ResultDelegate.qml:231
> + enabled: modelData.enabled !== false
> + ToolTip.visible: hovered && ToolTip.text.length > 0
> + ToolTip.text: {
QQC2 tooltip stuff doesn't really work for KRunner because they're not separate
windows :(
Also, don't use `ToolTip` attached property as it cannot respect the theme's
delay settings
REPOSITORY
R112 Milou
REVISION DETAIL
https://phabricator.kde.org/D22540
To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
