ngraham added a comment.
In D19364#421341 <https://phabricator.kde.org/D19364#421341>, @rooty wrote: > In D19364#421161 <https://phabricator.kde.org/D19364#421161>, @ngraham wrote: > > > Yep, needs an outline instead of a shadow when using software rendering, just like the other text with shadows. > > > I'll add an outline sure > > > Another thing is that in my previous attempt at this, I made the shadows optional, since there are places where `ActionButtons` are used that don't require any additional contrast for the text, such as on the logout screen. So it's best to omit them there. You can see how I did that in D16031 <https://phabricator.kde.org/D16031>, and it might be nice to do it here, too. > > Isn't that true of UserDelegate too though? > > F6643431: image.png <https://phabricator.kde.org/F6643431> > > We could separate the files, use separate versions for the login screen and the lock screen. That's why I haven't pushed the clock/userdelegate patch yet That's true, yeah. No need to create separate files, just add a public property in actionButton that's connected to the shadow/outline visibility. property alias labelShadow: labelShadow.visible And then on the login screen itself, you would set `labelShadow: true` for each ActionButton added there, and in the logout screen, you would set `labelShadow: isLightColor ? false : true` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19364 To: rooty, #vdg, ngraham, filipf Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
